Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special character will be removed in password section. #163

Open
bari86 opened this issue May 8, 2022 · 3 comments
Open

Special character will be removed in password section. #163

bari86 opened this issue May 8, 2022 · 3 comments

Comments

@bari86
Copy link

bari86 commented May 8, 2022

I am not sure if this is a bug or what, but somehow, for a password, if I enter as:

djasd$*ghr

it will become

djasdghr

This is true for root/sudo password, but I cant remember if its happening with db password or not. it might be for all special characters?

@jessuppi
Copy link
Member

Thanks for reporting this @bari86

After reviewing the behavior by trying a complex password string, I found an example result like this in ss-config:

SUDO_PASSWORD="asG$Y#$y3%UW#%U31#@#%#%@SUDO_PASSWORD#%7"

So I thought what's happening is the ss-install wizard's sed commands were not properly delimiting the variables, because we previously weren't using curly brackets. The code is now much better optimized:

Ref: 99361db

However, after I tested again, I saw a similar problem:

Something like 512fa#$W#yW#%yW$%Uw4U%u!!3@$T245&$%&$7%&*^&*685785 ... is changing to like:

512fa#$W#yW#%yW$%Uw4U%u!!3@$T245@SUDO_PASSWORD$%@SUDO_PASSWORD$7%@SUDO_PASSWORD*^@SUDO_PASSWORD*685785

... the & symbol is being replaced with @SUDO_PASSWORD string...

I'm looking into what's causing this demonic behavior, in the meantime all feedback is welcome. Also, for the record, I haven't experienced any "stripping" of special characters like you mentioned originally.

@jessuppi
Copy link
Member

jessuppi commented Jun 6, 2022

Update: in case this is related, we no longer bundle Force Strong Hashing as a MU plugin anymore.

@bari86
Copy link
Author

bari86 commented Aug 16, 2022

If this is confirm solved, then the issue can be close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants