Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a unit test for the k8s custom liveness check python script #22

Open
dargasudarshan opened this issue Sep 28, 2018 · 3 comments
Open

Create a unit test for the k8s custom liveness check python script #22

dargasudarshan opened this issue Sep 28, 2018 · 3 comments
Labels
good first issue Good for newcomers Hacktoberfest issue-taken python

Comments

@dargasudarshan
Copy link
Contributor

FEATURE REQUEST

What happened:

The k8s custom liveness check python script needs a unit-test to be created (Refer: https://github.com/openebs/test-tools/blob/master/custom-client/liveness.py)

Anything else we need to know?:

References :
https://stackoverflow.com/questions/652292/what-is-unit-testing-and-how-do-you-do-it
http://pythontesting.net/framework/unittest/unittest-introduction/
@michizhou
Copy link

michizhou commented Oct 2, 2018 •
edited

@dargasudarshan I would like to work on this issue. Any specific test cases you had in mind?

@akashicMarga
Copy link

Hi, I would like to work on this issue.

@dargasudarshan
Copy link
Contributor Author

@Aki58 Thanks, yeah please go ahead. Let us know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest issue-taken python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akashicMarga @dargasudarshan @michizhou