Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Pipeline Fixes #379

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

neelanjan00
Copy link
Member

@neelanjan00 neelanjan00 commented May 17, 2022

Proposed changes

  • Removes DEVICE_NAME from GCP pipeline and gcp-vm-disk-loss experiment BDD ENVs.
  • Updates the zones of GCP resources from us-central1-a to us-east1-b to avoid resource bottlenecking in a single zone (using a secret)
  • Removes DeviceNames from TestDetails structure.

Which Issues it Fixes

How has this been tested:

  • Test environment
    • GKE
    • AWS
    • OpenShift
    • KinD/k3s/k3d cluster
    • Others
  • Tested with production environment ( For ChaosCenter Tests )
  • Have not tested

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • I have added necessary documentation (if appropriate)
  • I have added Screenshots or Terminal snippets in the PR comment to validate the successful execution of changes

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • data-cy=* parameters have been added in codebase ( ChaosCenter Tests )
  • data-cy=* parameters need to be added in codebase ( ChaosCenter Tests )
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. uncaught exceptions from 3rd party library (if any)

Issue

  • Tasks in issue are checked off

Notes For Reviewer
Demo Github Action execution with the changes: https://github.com/neelanjan00/litmus-e2e/actions/runs/2336553137
https://github.com/neelanjan00/litmus-e2e/actions/runs/2427722494

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@neelanjan00 neelanjan00 added bug Something isn't working kind/enhancement New feature or request labels May 17, 2022
@neelanjan00 neelanjan00 self-assigned this May 17, 2022
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove DEVICE_NAMES in GCP Pipeline Update GCP Pipeline Zone
4 participants