Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Litmus-Portal): Workflow-Scheduling & MyHub Issues #254

Open
26 of 37 tasks
Jonsy13 opened this issue Apr 15, 2021 · 5 comments
Open
26 of 37 tasks

(Litmus-Portal): Workflow-Scheduling & MyHub Issues #254

Jonsy13 opened this issue Apr 15, 2021 · 5 comments
Assignees
Milestone

Comments

@Jonsy13
Copy link
Collaborator

Jonsy13 commented Apr 15, 2021

This Issue is created for tracking issues in Workflow scheduling & MyHubs user flow -

Scheduling/Browsing/Visualisation user-flow

  • Probe modal inputs not having validations for empty strings. ( Able to create a probe without any name)
  • Edit Sequence not working.
  • Edit buttons on Verify and commit screen not working.
  • While showing workflow, we have to check kind, Currently crashing for kind CronWorkflow.
  • Error not shown when selected resource(app label and appns) is not available.
  • Revert Chaos stays appended in the manifest even after setting it to false after setting it to True at the first flow.
  • Add units in Probes modal
  • Chaos Engine are getting saved after editing but clicking on the close button. (Shouldn’t be saved)
  • Input trimming and empty string checks needed in probes data.
  • “View the application details” needs to change to the icon button.
  • Editor is appending revert-chaosin uploaded yaml, shouldn't be added.
  • Edit schedule is crashing sometimes.
  • As a viewer, the user is able to configure everything for workflow scheduling (Can proceed upto verify and commit screen) but can’t schedule, backend RBAC is handling this case. We don't do any frontend checks?
  • CSS issue in Add Experiment Modal.
  • Image was not handled for some phases - Omitted, Skipped and Error.
  • Subject is a label, should not have slash in it's value. It can be underscore.
  • After disabling a schedule, enable schedule is not coming in dropdown.
  • Underscore should be added after namespace instead of hyphen in context.
  • MyHub Dropdown in scheduling screen showing failed myhubs too. ( Reported by @rajdas98 )
  • It should be litmusctl agent connect
    Screenshot from 2021-05-15 00-03-17
  • UI for radio button on agent screen, showing multiple selection
    Screenshot from 2021-05-17 16-08-01
  • After selecting "Save Changes" in YAML editor the workflow is not getting visualized.
  • For first time scheduling, the sub-options are not preselected on choose a workflow screen. The next button is enabled and the user is able to proceed without any alert.
  • Workflow name shows wrong error for valid name when number of characters increases after a limit (88 characters).
  • Workflows fail, when the workflow_name of 88 chars is given. After 88 characters, timestamp also got appended. (Need to investigate this ). Argo graphs also don't look good in this case. (some edge case)
  • Workflows with 2 same experiments not working.
  • App Labels are getting repeated, Need to show only unique values.
  • Edge case handling for k8s workflows - k8s-calico etc.
  • Workflow name edge case not handled in verify and commit screen.
  • When we paste a wrong intended YAML in the editor, it is pasting twice. ( Reported by @rajdas98 )
  • While searching a predefined workflow, frontend is showing "No predefined experiments present"
    Screenshot from 2021-09-13 10-10-55
  • When switching method from Get to Post or vice versa in a probe, frontend is crashing.
  • After editing subject in yaml, not getting reflected on verify & commit screen.

MyHubs -

  • Able to give empty url and branch and details are getting saved for later use. (Errors are displayed by input fields.)
  • Copy button ( for copying the kubectl apply ) not working on the chart page of myhub. [Not Secure Network should be the case]
  • In breadcrumb, clicking on the category name leads to Home page. As that page doesn’t actually exist.

Backend Issues

@S-ayanide
Copy link
Member

S-ayanide commented Apr 16, 2021

Bug Fix

  • Revert Chaos stays appended in the manifest even after setting it to false after setting it to True at the first flow. [🔀]
  • While showing workflow, we have to check kind, Currently crashing for kind CronWorkflow. [🔀]
  • Edit Sequence not working [🔀]
  • Editor is appending revert-chaosin uploaded yaml, shouldn't be added. [🔀]
  • Edit buttons on Verify and commit screen not working. [🔀]
  • Fixed Next button not working bug for CronWorkflow [🔀]
  • CSS issue in Add Experiment Modal. [🔀]
  • Subject is a label, should not have slash in it's value. It can be underscore. [🔀]
  • Workflow name edge case not handled in verify and commit screen. [🔀]
  • Workflows fail, when the workflow_name of 88 chars is given. After 88 characters, timestamp also got appended. (Need to investigate this ). Argo graphs also don't look good in this case. [🔀] -> Total length 64 chars not 88 chars
  • Underscore should be added after namespace instead of a hyphen in context. [🔀]
  • After selecting "Save Changes" in the YAML editor the workflow is not getting visualized. [🔀]
  • Delete Kubernetes Conformance Test Heder in Reliability Score Page [🔀]

Assigned : @S-ayanide

@saswatamcode
Copy link
Member

saswatamcode commented Apr 20, 2021

Bug Fix

  • Add units in Probes modal [🔀]
  • Able to give empty url and branch and details are getting saved for later use. (Errors are displayed by input fields.) [🔀]

Assigned: @saswatamcode

@amityt
Copy link
Contributor

amityt commented Apr 27, 2021

Bug Fix

  1. Probe modal inputs not having validations for empty strings. ( Able to create a probe without any name)
  2. Edit Sequence not working.
  3. Error not shown when selected resource(app label and appns) is not available.
  4. Chaos Engine are getting saved after editing but clicking on the close button. (Shouldn’t be saved)

@SarthakJain26
Copy link

SarthakJain26 commented Apr 30, 2021

  • BUG
    Next Button not responding on Tune Workflow Step while scheduling a workflow.
    Steps to generate this issue:
    • Schedule a workflow
    • Create a new workflow using the experiments from MyHub
    • Add a new experiment in Tune Worflow
    • Select recurring schedule
    • Go back to Tune Workflow step, click on next button.

@Jonsy13 @amityt @S-ayanide

@S-ayanide
Copy link
Member

BUG
Next Button not responding on Tune Workflow Step while scheduling a workflow.
Steps to generate this issue:

  • Schedule a workflow
  • Create a new workflow using the experiments from MyHub
  • Add a new experiment in Tune Worflow
  • Select recurring schedule
  • Go back to Tune Workflow step, click on next button.

@Jonsy13 @amityt @S-ayanide

This issue will be fixed by PR#2772
litmuschaos/litmus#2772

@ajeshbaby ajeshbaby added this to the 2.0-Beta7 milestone May 10, 2021
S-ayanide added a commit to litmuschaos/litmus that referenced this issue May 10, 2021
#2772)

Signed-off-by: Sayan Mondal <sayan@chaosnative.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants