Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint integration in CI #276

Open
rahulchheda opened this issue Sep 29, 2020 · 3 comments · May be fixed by #490
Open

Add golangci-lint integration in CI #276

rahulchheda opened this issue Sep 29, 2020 · 3 comments · May be fixed by #490
Assignees
@Nageshbansal
Labels
area/ci ci changes

Comments

@rahulchheda
Copy link
Member

rahulchheda commented Sep 29, 2020 •
edited

FEATURE REQUEST

  • In current CI, we have lint checks, but they seem not to detect all the linting issues, where as we can use golanglint-ci instead, which let use many linting plugins such as whitespaces, goimports, and many more, and these can be configured using config.
    ref: https://golangci-lint.run/usage/install/#ci-installation

Choose one: BUG REPORT or FEATURE REQUEST

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
@rahulchheda
Copy link
Member Author

cc: @ksatchit

This was referenced Oct 22, 2020
Closed
Closed
@Nageshbansal
Copy link
Contributor

hey @rahulchheda, can I work on this?

@neelanjan00
Copy link
Member

@Nageshbansal please feel free to get started, do let me know if you face any difficulty :)

@neelanjan00 neelanjan00 added the area/ci ci changes label Mar 14, 2024
@kartikaysaxena kartikaysaxena linked a pull request Apr 12, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nageshbansal Nageshbansal

Labels
area/ci ci changes
Projects
None yet
Milestone
No milestone
3 participants
@neelanjan00 @rahulchheda @Nageshbansal