Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support qtquickcompiler #282

Open
vimpostor opened this issue Feb 12, 2019 · 2 comments
Open

Support qtquickcompiler #282

vimpostor opened this issue Feb 12, 2019 · 2 comments

Comments

@vimpostor
Copy link
Member

It would be cool, if there was a simple way to enable the qtquickcompiler for Fluid.

Maybe enable it for Release builds like this:

CONFIG(debug, debug|release) {
	message("Running debug build")
}

CONFIG(release, debug|release) {
	message("Running release build")
	CONFIG += qtquickcompiler
}

I tried to enable the qtquickcompiler from the top level subdirs qmake project, by using CONFIG += qtquickcompiler, but it seemed to have no effect at all, and when I put it into the src/src.pro it seems to have no effect for Fluid, just for my own QML files.

Do you know any way to enable the qtquickcompiler for Fluid, when using it from an project?

You can test, if the qtquickcompiler is working, by putting nonsense into a QML file and seeing if it finds the errors at compile time:

// beginning of a qml file
nonsense to trigger qtquickcompiler

// ...
import QtQuick 2.12

When I put nonsense into my own QML files, it is detected at compile time, but if I put it into Fluid files, it is detected at runtime. So, I have to assume that the qtquickcompiler is not working for Fluid automatically.

Is there any way to enable it for Fluid?

This would improve performance and startup time.

@soheilarmin
Copy link

qtquickcompiler looks into resources to compile .qml files and these files are not included in the qrc resources for Fluid.

@plfiorini
Copy link
Member

QtQuickCompiler requires at least Qt 5.11, might as well raise the requirement to Qt 5.12 LTS.
I'm looking into it, testing with Liri Shell first.
Adding support to cmake-shared to automatically use the compiler if found: lirios/cmake-shared#6

plfiorini added a commit that referenced this issue May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants