Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lowR in BitcoinJsWalletProvider #392

Open
matthewjablack opened this issue Mar 24, 2021 · 2 comments
Open

Support for lowR in BitcoinJsWalletProvider #392

matthewjablack opened this issue Mar 24, 2021 · 2 comments

Comments

@matthewjablack
Copy link
Contributor

bitcoinjs-lib added the ability to always have low R values during transaction creation: bitcoinjs/bitcoinjs-lib#1442

This means signature size is at most 71 bytes, and maxWitnessLen goes from 108 to 107

It also has other benefits, such as saving several bytes on txs for multisigs: bitcoinjs/bitcoinjs-lib#1175 (comment)

Would be great if there were a way to force low R values during transaction creation, or default to this for CAL.

@matthewjablack matthewjablack changed the title Support for lowR in Bitcoin Js Wallet Provider Support for lowR in BitcoinJsWalletProvider Mar 24, 2021
@matthewjablack
Copy link
Contributor Author

This could be as simple as modifying the lowR value in ECPair class when returning keyPair from BitcoinJsWalletProvider: https://github.com/bitcoinjs/bitcoinjs-lib/blob/533d6c2e6d0aa4111f7948b1c12003cf6ef83137/src/ecpair.js#L19

@kraikov
Copy link
Collaborator

kraikov commented May 12, 2022

@monokh any actions here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants