Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset to defaults in settings of applets doesn't take effect #5985

Closed
NikoKrause opened this issue Nov 20, 2016 · 3 comments
Closed

Reset to defaults in settings of applets doesn't take effect #5985

NikoKrause opened this issue Nov 20, 2016 · 3 comments

Comments

@NikoKrause
Copy link
Member

E.g. you are messing around with the options in the settings of the menu-applet.
You can click on the "burger" symbol in the top right corner and then "Reset to defaults".
You have to restart Cinnamon to get to the default state. In Cinnamon 2.8.8 you didn't had to restart. So I guess it's a regression.

I think the bug is hidden somewhere here 3478db2
(@collinss cough cough ;)

@JosephMcc
Copy link
Contributor

It actually resets the settings in the window, they just don't take effect.

@Odyseus
Copy link
Contributor

Odyseus commented Nov 21, 2016

Hello, g@ys.

I have been trying to fix this, but without success (it turned out to be way out of my league).

To give more details to the issue/s.

  • After resetting the settings to their default values, the settings window reflect the changes and the settings file for that settings instance is changed and saved. The xlet doesn't reflect those changes unless Cinnamon is restarted.
  • Something similar happens when importing from an exported settings file. The imported values will be reflected in the settings window, but the xlet remains unaffected by those new settings. Restarting Cinnamon will make the xlet read the settings file and reflect the new values.

I think that the problem is in the settings bindings.

  • Currently, on Cinnamon 3.0.7, all settings files are constantly monitored. If one manually changes a setting in a settings file, it will take effect immediately on the xlet, but the setting window will not be aware of that change.
  • But in Cinnamon 3.2.x, the settings files are monitored only when the settings window is open. If one changes a setting value manually on a settings file, the setting change is immediately reflected on the settings window, but not in the xlet.

@collinss
Copy link
Member

Oh, I think I might know what is going on. My guess is that I didn't worry about sending signals from the settings window to cinnamon because I originally had a file monitor in settings.js. However, due to 864f632, there is no longer a file monitor in settings.js so it doesn't get updated. I'm not working this week after tomorrow (due to the holiday), so I should be able to fix this later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants