Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/cmd/linuxkit/moby/docker.go should use the Docker API #3854

Open
dgageot opened this issue Oct 17, 2022 · 1 comment
Open

src/cmd/linuxkit/moby/docker.go should use the Docker API #3854

dgageot opened this issue Oct 17, 2022 · 1 comment

Comments

@dgageot
Copy link
Contributor

dgageot commented Oct 17, 2022

I'm not sure why this file is shelling out to the docker CLI when the rest of the code is using directly the Docker API.
The result is that docker needs to be installed for this code to work properly when the rest of the code doesn't.

@deitch any idea?
@deitch
Copy link
Collaborator

deitch commented Oct 17, 2022

Not a clue. I'm guessing it was just missed. Happy to take a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgageot @deitch