Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with testcases/kernel/fs/doio/rwtest #1104

Open
cmcgcc opened this issue Nov 28, 2023 · 3 comments
Open

Issue with testcases/kernel/fs/doio/rwtest #1104

cmcgcc opened this issue Nov 28, 2023 · 3 comments
Assignees

Comments

@cmcgcc
Copy link
Contributor

cmcgcc commented Nov 28, 2023

Hello,

if test -h $(which df)

This line of rwtest clears dir and dfOpts options if it is a symlink because a symlink to busybox does not take options as described in the comments. But we see cases with a symlink to df.coreutils which works well with options.
I think more granular check is needed like

-                        if test -h $(which df)
-                           then
-                               dir=""; dfOpts="";
-                        fi
+			if [[ "$(readlink -f "$(which df)")" == *"busybox"* ]]
+			then
+				dir=""; dfOpts="";
+			fi

Thanks

@metan-ucw
Copy link
Member

Can you send a proper signed patch please?

@pevik
Copy link
Member

pevik commented Nov 30, 2023

@pevik
Copy link
Member

pevik commented Nov 30, 2023

Also note: #1110

@pevik pevik self-assigned this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants