Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason to continue using puppeteer: 1.13.0 ? #135

Open
acanimal opened this issue Sep 16, 2020 · 3 comments
Open

Any reason to continue using puppeteer: 1.13.0 ? #135

acanimal opened this issue Sep 16, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@acanimal
Copy link

Puppeteer is at version 5. Why is the project continue depending on the version 1?

I currently found that --lang values passes as the puppeteerArgs are ignored and seems it is a chromium bug.

Any possibility to upgrade the version? At least until version 3 which requires node 10

@leonardiwagner
Copy link
Member

Hi @acanimal , actually only due to former stability.. it's working.. so 🤷 , however if you have a reason to update, let's do it!

We can update to version 3 if it's the latest to support node 10, no problems. Pull requests are appreciated.

@leonardiwagner leonardiwagner added the enhancement New feature or request label Sep 18, 2020
@acanimal
Copy link
Author

Lets try to get some free time this weekend 🚀

@neverton1970
Copy link

Hi,
I noticed the scraper stopped working in the last few days, but we use a proxy service and the browser was crashing as soon as it was opened. I wasn't sure if it because we're using authentication or not and puppeteer 1.13 didn't like an update.

On a pure guess, I've updated puppeteer 1.13 to 5.1.0 and it's now working fine, with authentication so my current working theory is that the proxy provider ( can't remember their name off the top of my head) have possibly updated the authentication and the old 1.13 version can't handle it. Upgrading it to 5.1.0 appears to be working fine. 

Obviously not a full regression test, but the 10-15 accounts I've tried to scrape so far, have worked fine under 5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants