-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove enableSecondPrecision
#44
Comments
Hi, can i work on this issue. |
Hey @kunalshokeen051 - thanks for offering your help. Sure thing! By the way @falvarez1 - do you see any reason against removing the flag and releasing it in |
No problems. After adding the automatic detection the only reason for keeping it is backwards compatibility. We just need to document as a breaking change. |
Yeah, that said, @kunalshokeen051 feel free to make the changes. |
Given that there was no response for 2 weeks I will unassign the ticket so anyone who wants to help, can do so. |
The
enableSecondPrecision
flag is no longer needed since we automatically determine whether or not we want that precision.So, there is no benefit for the user. While this is a major breaking change, I am still inclined to say it is fine to do in
v2
.The text was updated successfully, but these errors were encountered: