Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enableSecondPrecision #44

Open
linkdotnet opened this issue May 7, 2024 · 5 comments
Open

Remove enableSecondPrecision #44

linkdotnet opened this issue May 7, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@linkdotnet
Copy link
Member

The enableSecondPrecision flag is no longer needed since we automatically determine whether or not we want that precision.

So, there is no benefit for the user. While this is a major breaking change, I am still inclined to say it is fine to do in v2.

@linkdotnet linkdotnet added the good first issue Good for newcomers label May 7, 2024
@kunalshokeen051
Copy link

Hi, can i work on this issue.

@linkdotnet
Copy link
Member Author

Hey @kunalshokeen051 - thanks for offering your help. Sure thing!
If you have any questions, feel free to let us know.

By the way @falvarez1 - do you see any reason against removing the flag and releasing it in v2?

@falvarez1
Copy link
Member

No problems. After adding the automatic detection the only reason for keeping it is backwards compatibility. We just need to document as a breaking change.

@linkdotnet
Copy link
Member Author

Yeah, that said, @kunalshokeen051 feel free to make the changes.
You might want to add an entry about the migration to the docs. Basically telling folks that they don't need that entry as it is automatically inferred.

@linkdotnet
Copy link
Member Author

Given that there was no response for 2 weeks I will unassign the ticket so anyone who wants to help, can do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants