Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing on macos #814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ssbarnea
Copy link

Fixes: #813

@ssbarnea ssbarnea marked this pull request as ready for review March 26, 2024 10:10
@ssbarnea
Copy link
Author

@cjmayo hi! maybe allowing action to run by default? I don't see any security issue in that. Is bit frustrating to not even be able to test the PR.

@cjmayo
Copy link
Contributor

cjmayo commented Apr 4, 2024

It does fail "##[error]docker: command not found", not very helpful - my guess is that the name is not unique because it is"Python ${{ matrix.python-version }}".

@cjmayo
Copy link
Contributor

cjmayo commented Apr 4, 2024

or it could just be that runner...

Current runner version: '2.314.1'
Operating System
  macOS
  14.4.1
  23E224
Runner Image
  Image: macos-14-arm64
  Version: 20240402.2
  Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240402.2/images/macos/macos-14-arm64-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240402.2

@cjmayo
Copy link
Contributor

cjmayo commented Apr 4, 2024

The second one, looks like no docker on macOS runners. I take it back about the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run tests on macos due to missing GeoIP.h
2 participants