Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Number of Connected Neighbors > 4 Can Lead to Crashes #119

Open
johngallo opened this issue Mar 17, 2021 · 4 comments
Open

Max Number of Connected Neighbors > 4 Can Lead to Crashes #119

johngallo opened this issue Mar 17, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation linkage pathways Relating to Linkage Pathways tool

Comments

@johngallo
Copy link
Member

  1. make sure the default number of linkages is 4
  2. In the help dialog in the tool, indicate that a number higher than 4 may cause crashes, and is only advised if also running linkage priority tool too.
  3. consider making the user check a radio box to allow them to do a value higher than 4, and askingthem to read the above disclaimer.
@dkav
Copy link
Contributor

dkav commented Mar 18, 2021

@johngallo are you referring to Step 4 Option A - Maximum Number of Connected Neighbors?

Do you know why the crashes are occurring? It would be helpful to have more detail.

@johngallo
Copy link
Member Author

johngallo commented Mar 18, 2021 via email

@dkav
Copy link
Contributor

dkav commented Mar 19, 2021

I am not sure about this. If one runs the tool skipping step 4 will you not run into the same problem? If not, then the issue is with how the prunning is done or how constellations are formed. Without a crash report it is hard to tell.

  • make sure the default number of linkages is 4

The default number is 4.

  • In the help dialog in the tool, indicate that a number higher than 4 may cause crashes, and is only advised if also running linkage priority tool too.

I don't think you should give a specific number or advise for LP only– each user's configuration and needs will differ. You can highlight the implications but that would apply, as far as I understand, to running the tool and skipping step 4.

  • consider making the user check a radio box to allow them to do a value higher than 4, and askingthem to read the above disclaimer.

Radio buttons don't exist for the toolbox, only check boxes. Either way, you are adding more complexity to the tool.

@dkav dkav changed the title max number of linkages: Documentation and/or Dev improvements Max Number of Connected Neighbors > 4 Can Lead to Crashes Mar 19, 2021
@venkanna37 venkanna37 added the linkage pathways Relating to Linkage Pathways tool label Mar 24, 2021
@johngallo
Copy link
Member Author

The low hanging fruit here would be to add the "bomb" icon to the user guide and talk about this there.

@johngallo johngallo added the documentation Improvements or additions to documentation label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation linkage pathways Relating to Linkage Pathways tool
Projects
None yet
Development

No branches or pull requests

3 participants