Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Context Menus #508

Open
alexsb opened this issue Nov 17, 2021 · 7 comments
Open

Provide Context Menus #508

alexsb opened this issue Nov 17, 2021 · 7 comments
Assignees
Labels
status: help wanted Extra attention is needed type: feature New feature or request

Comments

@alexsb
Copy link
Contributor

alexsb commented Nov 17, 2021

We'd like the ability to use context menus going forward. To do that, we need to develop a way for lineup to trigger context menus, but let an external party (like datavisyn) style and customize them (e.g., remove individual entries, or add new ones based on hooks).

It would also be good if LineUp and datavisyn used the same library to do context menus; I think lineup is using popper.js for menus, and datavisyn wants to use popper.js for tool tips, but might be using bootstrap for menus?

@thinkh thinkh added the type: feature New feature or request label Nov 18, 2021
@sgratzl
Copy link
Member

sgratzl commented Nov 19, 2021

easiest and most generic solution is using a contextmenu listener on the root element and check which element was pressed.

e.g. https://codepen.io/sgratzl/pen/RwZvXrQ?editors=0011

@alexsb
Copy link
Contributor Author

alexsb commented Nov 19, 2021

@thinkh any thoughts on whether that would be compatible with our needs?

@sgratzl sgratzl self-assigned this Nov 30, 2021
@thinkh
Copy link
Member

thinkh commented Dec 3, 2021

Yes, that would work. The question whether or not we want a context menu for a single cell.

In case we want to reduce/remove the toolbar from the column header and move some parts into the context menu, the context menu should be already part of the LineUp library.

@alexsb
Copy link
Contributor Author

alexsb commented Dec 13, 2021

I'd advocate for removing the tool bar from the column header. It results in a lot of buttons and clutters the view.

@sgratzl sgratzl added the status: help wanted Extra attention is needed label Dec 23, 2021
@alexsb
Copy link
Contributor Author

alexsb commented Feb 11, 2022

What would we have to do to move this forward?

@dvdanielamoitzi
Copy link

Are there any updates on this? We'd like to implement context menus for our apps and it would be great if lineup would also support that. Is there anything you need from our side @sgratzl?

@alexsb
Copy link
Contributor Author

alexsb commented May 30, 2022

Can we be specific on how this would be implemented? @thinkh could you come up with a proposal please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted Extra attention is needed type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants