Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall Search Functionality #498

Open
alexsb opened this issue Nov 5, 2021 · 5 comments
Open

Overall Search Functionality #498

alexsb opened this issue Nov 5, 2021 · 5 comments
Labels
status: help wanted Extra attention is needed type: feature New feature or request

Comments

@alexsb
Copy link
Contributor

alexsb commented Nov 5, 2021

We should have a global, always visible search box in tool bars that searches for a term or a number across all columns as you type.

These items should be filtered, as in the baby name wizard: https://www.babynamewizard.com/voyager#prefix=&sw=both&exact=false

This should be a globally exposed function LineUp provides that can be easily implemented by wrapping applications.

The LineUp demo should also have a search bar.

@alexsb
Copy link
Contributor Author

alexsb commented Nov 16, 2021

This should be a globally exposed function.

@thinkh thinkh added priority: high fix it or we are all doomed type: feature New feature or request and removed priority: high fix it or we are all doomed labels Nov 16, 2021
@alexsb alexsb changed the title Overall Search Box Overall Search Functionality Nov 16, 2021
@sgratzl
Copy link
Member

sgratzl commented Nov 19, 2021

the data provider already has a setFilter function https://github.com/lineupjs/lineupjs/blob/main/src/provider/LocalDataProvider.ts#L103 which allows to specify a filter function on top of all the column filters. So, one can implement a custom search in this way by adding a search field somewhere and implement the filter function to implement the filter logic.

@alexsb
Copy link
Contributor Author

alexsb commented Nov 22, 2021

OK, @thinkh, is this sufficient, or should LineUp provide a wrapper that's potentially easier to use?

@thinkh
Copy link
Member

thinkh commented Dec 3, 2021

Yes, that would work for our use cases.

@alexsb
Copy link
Contributor Author

alexsb commented Dec 13, 2021

Is a wrapper hard? It seems that this could be a widely-used feature, and asking every client app to re-implement it doesn't seem to make sense.

@sgratzl sgratzl added the status: help wanted Extra attention is needed label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted Extra attention is needed type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants