Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Label from Visualizations #491

Open
alexsb opened this issue Nov 5, 2021 · 2 comments
Open

Separate Label from Visualizations #491

alexsb opened this issue Nov 5, 2021 · 2 comments
Labels
type: feature New feature or request

Comments

@alexsb
Copy link
Contributor

alexsb commented Nov 5, 2021

Labels can very often be combined with visualizations for individual items.

Instead of having labels be part of a visualization, it should probably be a separate thing that we can switch on for items (not for groups or summaries).

Options could be just binary ("Show Label"), or it could be three states:

  • Show Label
  • Show Label for Selected
  • No Label
@sgratzl
Copy link
Member

sgratzl commented Nov 19, 2021

a complex request since each renderer defines the content of a cell. In order to add labels as another layer on top of each, the cells needs to be wrapped such that the renderer renders in a child of cell and not the cell anymore. This also requires to adapt a lot of the CSS code since they assume that the cell = renderer space.

For some elements and cells a label can be very long, e.g. for a column with a long text, or multiple values. That might impact the performance

@alexsb
Copy link
Contributor Author

alexsb commented Nov 22, 2021

Hmm, ok, how about introducing two states then for each relevant renderer? One with label, one without. Would that be easier? If so, I can think through which ones would be affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants