Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy docs by github actions #521

Closed
Yang-33 opened this issue Oct 13, 2023 · 0 comments · Fixed by #868
Closed

Deploy docs by github actions #521

Yang-33 opened this issue Oct 13, 2023 · 0 comments · Fixed by #868
Labels
enhancement

Comments

@Yang-33
Copy link
Contributor

Yang-33 commented Oct 13, 2023 •
edited

like https://github.com/line/line-bot-sdk-php/blob/c6a17ce18c11d4cb16bd6dbb6ed0030cd983576a/.github/workflows/release.yml#L1

If we do this, we don't have to keep gh-pages branch.

(However, we don't have to use github actions for now....)
@Yang-33 Yang-33 mentioned this issue Jun 1, 2024
Merged
Yang-33 added a commit that referenced this issue Jun 4, 2024
@Yang-33
Stop using doc branch to use github pages (#868)
f324445 
`gh-pages` branch for documentation is no longer necessary. By using
GitHub Actions, you can utilize GitHub Pages directly.

This change supports that. Additionally, this change has made sure not
to update the documentation until the upload to npm is complete. This is
to prevent confusion among users if the documentation is updated but
package is not updated.

TODO: Modify settings in
https://github.com/line/line-bot-sdk-nodejs/settings/pages after this
change is merged

ref: https://vitepress.dev/guide/deploy#github-pages

Resolve #521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using doc branch to use github pages Yang-33/line-bot-sdk-nodejs
1 participant
@Yang-33