Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support distributed tracing #841

Open
ikhoon opened this issue Apr 28, 2023 · 1 comment
Open

Support distributed tracing #841

ikhoon opened this issue Apr 28, 2023 · 1 comment

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Apr 28, 2023

If distributed tracing is supported by a Central Dogma server, users can easily find a performance bottleneck in their request paths and visualize the dependencies of the Central Dogma server.

We will define a configuration for distributedTracing and make the server report tracing information based on that.

{ 
  "distributedTracing": {
    "collectorUrl": "http://127.0.0.1:.../api/../spans",
    "serviceName": "CentralDogma",
    "samplingRate": "0.01",
    ...
  }
}

A builder API can be also used to configure distributed tracing for both a server and a client.

@trustin
Copy link
Member

trustin commented Apr 28, 2023

We might want to wait for Micrometer Tracing integration in Armeria first though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants