Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I sign out, I should be redirected to the new sign up/sign in page #132

Open
tprudentova opened this issue Apr 26, 2024 · 14 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@tprudentova
Copy link

  1. You’re inside of twake drive
  2. Click Sign out
  3. You’re redirected to the lemon ldap page
    Expectation: you're redirected to the new sign-up page
Screen.Recording.2024-04-26.at.10.37.20.mov
@tprudentova tprudentova added the enhancement New feature or request label Apr 26, 2024
@guimard
Copy link
Member

guimard commented Apr 29, 2024

Hi @rezk2ll, which way do you use to signup ?

@guimard
Copy link
Member

guimard commented Apr 29, 2024

@tprudentova : before fixing this we have to fix sub-issues : Tdrive isn't compatible with OIDC logout, then even if you're disconnected from SSO, you might be considered as still connected by Tdrive

@rezk2ll
Copy link
Member

rezk2ll commented Apr 29, 2024

Hi @rezk2ll, which way do you use to signup ?

Hi, we use /?login to display the login form directly and / for normal signup

@guimard
Copy link
Member

guimard commented Apr 29, 2024

Hi @rezk2ll, which way do you use to signup ?

Hi, we use /?login to display the login form directly and / for normal signup

Sorry, my question was about signout. Probably /?logout=1

@rezk2ll
Copy link
Member

rezk2ll commented Apr 29, 2024

Hi @rezk2ll, which way do you use to signup ?

Hi, we use /?login to display the login form directly and / for normal signup

Sorry, my question was about signout. Probably /?logout=1

for registration it's /logout

@guimard
Copy link
Member

guimard commented Apr 29, 2024

OK, then let's wait for Tdrive logout

@shepilov
Copy link
Member

@guimard How the redirect url after logout is connected to the backlog out channel for oidc?
Right now you have that same behavior for Twake Mail as well, after logout you are redirected to the LemonLDAP page https://auth.stg.lin-saas.com/ and not to the https://sign-up.stg.lin-saas.com/

@guimard
Copy link
Member

guimard commented Apr 30, 2024

@guimard How the redirect url after logout is connected to the backlog out channel for oidc? Right now you have that same behavior for Twake Mail as well, after logout you are redirected to the LemonLDAP page https://auth.stg.lin-saas.com/ and not to the https://sign-up.stg.lin-saas.com/

Not directly connected, however :

  • logout should not redirect to the caller app, prefer the login/registration page
  • logout should be hidden until we're sure that all applications really support logout. In my previous job, I preferred to totally hide logout feature instead of lying. User were prompted "Close you browser" .

@guimard
Copy link
Member

guimard commented Apr 30, 2024

SO let's define the global logout behavior we want, then I'll configure LLNG

@guimard
Copy link
Member

guimard commented May 1, 2024

Fixed in yadd/lemonldap-ng-* v2.18.2-11, pushed (Commit 6179515 inside TWP staging)

It requires also a new env variables (FIXED_LOGOUT_REDIRECTION) but I don't know where push it since lemonldap/values.yaml has no more environment paragraph, @ducnm0711 could you help here ?

@ducnm0711
Copy link

@guimard Hi Xavier what should be the default value for FIXED_LOGOUT_REDIRECTION? Boolean true/false or ?

@guimard
Copy link
Member

guimard commented May 1, 2024

@guimard Hi Xavier what should be the default value for FIXED_LOGOUT_REDIRECTION? Boolean true/false or ?

The URL to redirect after successful logout (https://sign-up...)

@shepilov shepilov assigned shepilov and ducnm0711 and unassigned guimard May 3, 2024
@ducnm0711
Copy link

implemented in lemonldap

https://ci.linagora.com/linagora/lrs/saas/deployments/twake/twake-workplace-preprod-apps/-/blob/main/configs/auth/twake-workplace-sso/default/values.yaml#L51

  FIXED_LOGOUT_REDIRECTION: {{ .Values.config.logoutRedirection | quote }}
  ------
  config:
    logoutRedirection: https://sign-up.stg.lin-saas.com

@shepilov
Copy link
Member

shepilov commented May 6, 2024

Still not working and should be fixed with #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants