Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User picker does not work well #50

Closed
1 of 3 tasks
RomaricMourgues opened this issue May 11, 2023 · 5 comments · Fixed by #444
Closed
1 of 3 tasks

User picker does not work well #50

RomaricMourgues opened this issue May 11, 2023 · 5 comments · Fixed by #444
Assignees
@ericlinagora
Labels
bug Something isn't working
Milestone
v1.0.3

Comments

@RomaricMourgues
Copy link
Contributor

RomaricMourgues commented May 11, 2023 •
edited by shepilov

Describe the bug

  • The user picker in access management doesn't work very well and doesn't match the current UI. We should rebuild it from scratch.
  • Also the users are not loaded until we open the picker
  • Also we will need to remove the anonymous user from user search

To Reproduce
Open account B and lookup a file access management created by user A, you will not see user A:

Before searching:
Screenshot 2023-05-11 at 10 58 02

After searching (user repository updated):
Screenshot 2023-05-11 at 10 58 07
@RomaricMourgues RomaricMourgues added the bug Something isn't working label May 11, 2023
@Aymerix01 Aymerix01 self-assigned this Jul 19, 2023
ericlinagora added a commit that referenced this issue Mar 12, 2024
@ericlinagora
💄 Make user selection dialog more acceptable in dark and normal mode (#…
b75b404 
…50)
ericlinagora added a commit that referenced this issue Mar 12, 2024
@ericlinagora
🚸 Show when user search results are incomplete (#50)
afc7f18
ericlinagora added a commit that referenced this issue Mar 12, 2024
@ericlinagora
🚸 Make more obvious right that is granted by adding user (#50)
1d12e17
@ericlinagora ericlinagora mentioned this issue Mar 12, 2024
Merged
@ericlinagora ericlinagora linked a pull request Mar 12, 2024 that will close this issue
#50 user picker UI improvements #444
Merged
@ericlinagora
Copy link
Contributor

Did some UI work on this. Search issues for me were related to elastic vs open search. The behaviour when adding a user isn't super clear to me, eg if a user has rights then is added with "no rights" in the drop down

@shepilov
Copy link
Member

@ericlinagora he can have right to the parent directory, but do not to the child one,
and if he has right to the parent directory it's do not displays in the list, that's why it's not clear for the user

@shepilov shepilov assigned ericlinagora and unassigned Aymerix01 Mar 14, 2024
@ericlinagora
Copy link
Contributor

Not sure I understand then, will need someone to show me

@shepilov
Copy link
Member

The new design for access management modal window https://www.figma.com/file/CWz4DatnJ7Qhl3JycJhbFY/TDrive---MUI3?type=design&node-id=1199-41375&mode=design&t=W8oEfqYP13t46wOD-0

ericlinagora added a commit that referenced this issue Apr 2, 2024
@ericlinagora
💄 Make user selection dialog more acceptable in dark and normal mode (#…
676055d 
…50)
ericlinagora added a commit that referenced this issue Apr 2, 2024
@ericlinagora
🚸 Show when user search results are incomplete (#50)
080bea2
ericlinagora added a commit that referenced this issue Apr 2, 2024
@ericlinagora
🚸 Make more obvious right that is granted by adding user (#50)
26dc16c
ericlinagora added a commit that referenced this issue Apr 7, 2024
@ericlinagora
💄 Applied sharing dialog changes from figme (#50)
065e2fa 
https://www.figma.com/proto/CWz4DatnJ7Qhl3JycJhbFY/TDrive---MUI3?type=design&node-id=1355-9893&t=7v0ocJCf6knnPDan-0&scaling=min-zoom&page-id=1189%3A23493&starting-point-node-id=1347%3A8530
ericlinagora added a commit that referenced this issue Apr 7, 2024
@ericlinagora
💄 Applied sharing dialog changes from figme (#50)
d72eb4a 
https://www.figma.com/proto/CWz4DatnJ7Qhl3JycJhbFY/TDrive---MUI3?type=design&node-id=1355-9893&t=7v0ocJCf6knnPDan-0&scaling=min-zoom&page-id=1189%3A23493&starting-point-node-id=1347%3A8530
ericlinagora added a commit that referenced this issue Apr 7, 2024
@ericlinagora
💄 Sharing dialog use actual document icon (#50)
ea63175
ericlinagora added a commit that referenced this issue Apr 9, 2024
@ericlinagora
💄 Sharing dialog use actual document icon (#50)
59ef69d
ericlinagora added a commit that referenced this issue Apr 10, 2024
@ericlinagora
♻️ frontend: document icon uses a lookup now (#50)
51c1242
@ericlinagora
Copy link
Contributor

https://www.figma.com/proto/CWz4DatnJ7Qhl3JycJhbFY/TDrive---MUI3?type=design&node-id=1585-1262&t=8xKOrMMDLhbkdmA5-0&scaling=min-zoom&page-id=1583%3A102&starting-point-node-id=1585%3A1262&hide-ui=1

ericlinagora added a commit that referenced this issue Apr 21, 2024
@ericlinagora
💄 Share dialog: make filename bold in title (#50)
a5ee84e
ericlinagora added a commit that referenced this issue Apr 21, 2024
@ericlinagora
♻️ front: Implemented user display logic in grouped rows user molecule (
b55d3fb 
#50)
ericlinagora added a commit that referenced this issue Apr 21, 2024
@ericlinagora
♻️💄 front: Use UserBlock from grouped rows in the access rights modal…
68400fa 
… (and a bit of dark mode borders) (#50)
ericlinagora added a commit that referenced this issue Apr 21, 2024
@ericlinagora
♻️ front: moved driveitem access entities editing to a helper file (#50)
9a7dce8
ericlinagora added a commit that referenced this issue Apr 21, 2024
@ericlinagora
✨ front: WIP: Add separate modal for public link (#50 v3)
ff5061c
ericlinagora added a commit that referenced this issue Apr 21, 2024
@ericlinagora
💄 front: adding slider like checkbox (#50)
339d4d7
ericlinagora added a commit that referenced this issue Apr 21, 2024
@ericlinagora
♻️ front: moved copy link button to own file (#50)
c4a9a6d
ericlinagora added a commit that referenced this issue Apr 21, 2024
@ericlinagora
🩹 front: fix react unknown property passed on by input (#50)
560909b
@shepilov shepilov mentioned this issue May 7, 2024
Closed
ericlinagora added a commit that referenced this issue May 9, 2024
@ericlinagora
⚰️ front: removing some unused code (#50)
0f9ee7f
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 Make user selection dialog more acceptable in dark and normal mode (#…
1a66a6f 
…50)
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
🚸 Show when user search results are incomplete (#50)
b121f6c
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
🚸 Make more obvious right that is granted by adding user (#50)
bfc2499
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 Applied sharing dialog changes from figme (#50)
579b649 
https://www.figma.com/proto/CWz4DatnJ7Qhl3JycJhbFY/TDrive---MUI3?type=design&node-id=1355-9893&t=7v0ocJCf6knnPDan-0&scaling=min-zoom&page-id=1189%3A23493&starting-point-node-id=1347%3A8530
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 Sharing dialog use actual document icon (#50)
5d05326
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
♻️ frontend: document icon uses a lookup now (#50)
78f98fa
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 Share dialog: make filename bold in title (#50)
668fbca
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
♻️ front: Implemented user display logic in grouped rows user molecule (
035fead 
#50)
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
♻️💄 front: Use UserBlock from grouped rows in the access rights modal…
8d42c09 
… (and a bit of dark mode borders) (#50)
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
♻️ front: moved driveitem access entities editing to a helper file (#50)
fc3ebaa
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
✨ front: WIP: Add separate modal for public link (#50 v3)
f23b9da
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 front: adding slider like checkbox (#50)
c2fb743
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
♻️ front: moved copy link button to own file (#50)
e083ce4
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
🩹 front: fix react unknown property passed on by input (#50)
e0fa40f
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 front: WIP Implementation of the design for the share link portion (#…
3a0e0a9 
…50)
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
⚰️ front: deleted unused update access dialog rows eg. inheritance (#50)
1924eca
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
🧑‍💻 front: added stories for access-level-dropdown and copy-link-butt…
7bc6e36 
…on (#50)
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
♻️ front: introduce confirm modal (#50)
ce1180d
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 front: Adding icons to context menu on drive items (#50)
5755e72
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
🩹 front: removing the password on an expired public link doesnt need …
a524df0 
…a warning (#50)
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 front: user rights search and add dialog (#50)
62dcb71
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 front: cosmetic changes (#50)
f803e4c
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 front: forgot a spot of red access level (#50)
cf35692
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
♻️ front: minor cleanup and refactoring (#50)
e6234f9
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
🩹 front: use logger instead of console (#50)
9048ce7
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
💄 front: fix dark mode text colour of public-link advanced settings (#50
9fc0934 
)
ericlinagora added a commit that referenced this issue May 13, 2024
@ericlinagora
⚰️ front: removing some unused code (#50)
3e2adf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericlinagora ericlinagora

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging a pull request may close this issue.

#50 user picker UI improvements linagora/twake-drive
4 participants
@RomaricMourgues @shepilov @Aymerix01 @ericlinagora