Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCM user notifcations should not fail if "no longer existing types" stored on the DB #958

Open
quantranhong1999 opened this issue Mar 7, 2024 · 1 comment
Labels

Comments

@quantranhong1999
Copy link
Member

Why

GIVEN at first TMail support a change type e.g. Thread, and user register updates for the Thread changes via FirebaseSubscription/set.
WHEN TMail gives up supporting the Thread change type
THEN:

  • FirebaseSubscription/get likely would fail as TypeStateFactory fails to parse the Thread type from DB
  • FirebasePushListener likely would fail as TypeStateFactory fails to parse the Thread type from DB

Expect: Should not fail if DB contains the "no longer existing types".

How

Be more lenient in TypeStateFactory: skip the parsing failure upon retrieval phase and a WARN level log cf: #956 (comment)

Notes

Could contribute this to PushSubscription on James side if suitable...

@chibenwa
Copy link
Member

chibenwa commented Mar 7, 2024

Idem for PushSubscriptions / james push?
(& JIRA ticket?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants