Storage interface for thumbnail

[quantranhong1999]

Why

The idea is to have an abstraction for thumbnail storage so it can be generic with implementations (maybe not for now as only S3, but other implementations in the future).

How

public interface ThumbnailStore {
    Publisher<Void> save(ThumbnailBlobId blobId, byte[] payload);

    Publisher<byte[]> readBytes(ThumbnailBlobId blobId);

    Publisher<Boolean> delete(ThumbnailBlobId blobId);
}

public class BlobStoreThumbnailStore implements ThumbnailStore {
    private final BlobStoreDAO blobStoreDAO;

    @Inject
    public BlobStoreThumbnailStore(BlobStoreDAO blobStoreDAO) {
        this.blobStoreDAO = blobStoreDAO;
    }

    @Override
    public Publisher<Void> save(ThumbnailBlobId blobId, byte[] payload) {
    }

    @Override
    public Publisher<byte[]> readBytes(ThumbnailBlobId blobId) {
    }

    @Override
    public Publisher<Boolean> delete(ThumbnailBlobId blobId) {
    }
}

public class ThumbnailBlobId {
    enum SIZE {
        SMALL,
        MEDIUM
    }

    public static class Factory {
        private final BlobId.Factory blobIdFactory;

        @Inject
        public Factory(BlobId.Factory blobIdFactory) {
            this.blobIdFactory = blobIdFactory;
        }

        public ThumbnailBlobId forAttachment(BlobId originalAttachmentBlobId, SIZE size) {
            ...
        }
    }

    private final BlobId blobId;

    private ThumbnailBlobId(BlobId blobId) {
        this.blobId = blobId;
    }
}

DoD

• Unit tests

[chibenwa]

S3ThumbnailStore -> BlobStoreThumbnailStore

[chibenwa]

Is the thumbnail store responsible of generating the thumbnail ?

Or should it allow storing both small and medium size?

[quantranhong1999]

Is the thumbnail store responsible of generating the thumbnail ?

No, my design tends to make ThumbnailStore only responsible for storing. We can let the thumbnail client handles generating the thumbnail.

Or should it allow storing both small and medium size?

As it stands now, it allows, with 2 separate request: 1 for small and 1 for medium.

ThumbnailBlobId is an abstraction layer so the ThumbnailStore do not need to care about the size of the thumbnails do we use (e.g in the future we add or remove the sizes).

That is my idea.

[Arsnael]

No medium for now

[Arsnael]

Thumbnail blob id should be the jmap blob id