Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve channel manager constructor considering RGS #122

Open
TheBlueMatt opened this issue Nov 17, 2022 · 2 comments
Open

Improve channel manager constructor considering RGS #122

TheBlueMatt opened this issue Nov 17, 2022 · 2 comments

Comments

@TheBlueMatt
Copy link
Collaborator

No description provided.

@jkczyz
Copy link

jkczyz commented Nov 17, 2022

A couple things that I noticed:

  • Disabling P2PGossipSync requires passing null for net_graph_serialized to the constructor.
  • But this will start the BackgroundProcessor with GossipSync.none(), which means any NetworkUpdates from failed payments won't be applied to the NetworkGraph

@jkczyz
Copy link

jkczyz commented Nov 21, 2022

Also:

  • InvoicePayer won't be initialized without a NetworkGraph, making the previous point irrelevant since there would be no event interception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants