Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better error messaging on null checks #121

Open
TheBlueMatt opened this issue Nov 2, 2022 · 0 comments
Open

Provide better error messaging on null checks #121

TheBlueMatt opened this issue Nov 2, 2022 · 0 comments

Comments

@TheBlueMatt
Copy link
Collaborator

Several times we've had nulls creep in from user code and cause us to do something scary like a 0-ptr deref, which leaves users confused and frustrated, eg https://github.com/orgs/lightningdevkit/discussions/1820. We really should instead null check and call jni->FatalError, even though its a bit more code, because it makes users much happier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant