Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump slf4j-api dependency to 2.x #402

Open
kamilkloch opened this issue Jun 21, 2023 · 3 comments
Open

Bump slf4j-api dependency to 2.x #402

kamilkloch opened this issue Jun 21, 2023 · 3 comments

Comments

@kamilkloch
Copy link

kamilkloch commented Jun 21, 2023

A mixture of 1.7 and 2.x breaks logging: https://www.slf4j.org/faq.html#changesInVersion200
(Logback 1.3+ already depends on slf4j-api 2.x).

@SethTisue
Copy link
Collaborator

not sure if this is a safe upgrade, or might be considered disruptive?

an example where it was considered disruptive: slick/slick#2542

@SethTisue
Copy link
Collaborator

SethTisue commented Aug 11, 2023

@analytically @jxnu-liguobin @mox692 thoughts on how to proceed here?

I have no understanding of the issues involved, but: I think a typical solution in situations like this would be to roll one more patch release before taking the upgrade, for those who want a fix for #387 without any other implications, then take the SLF4J upgrade and publish again, with an appropriate version number bump...?

@mox692
Copy link
Collaborator

mox692 commented Aug 12, 2023

Yes, I agree.
It would be safer to separate the fixes for #387 and the update of the slf4j-api 2.x into different releases. Considering the example of Slick, upgrading to slf4j-api 2.x might require careful consideration.
I'll investigate a safe upgrade approach for scala-logging when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants