Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logging facility #12

Open
prensing opened this issue Feb 1, 2019 · 0 comments
Open

Use logging facility #12

prensing opened this issue Feb 1, 2019 · 0 comments

Comments

@prensing
Copy link
Member

prensing commented Feb 1, 2019

Definitely low priority.

We should generally use the Python "logging" facility, although it might depend on what is done inside cscore and the related Python code.

logging let you have messages with different priority (debug, warning, etc) and you can set what is recorded. You can still send it to a file as needed.

One thing to remember though: if you have "logging.debug("foo")" everywhere, it will still slow down your code even if the "debug" messages are not saved. So low level logging code should still be used sparingly and/or commented out for "production".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant