Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: flaky test udp_recv_in_a_row #4219

Open
bnoordhuis opened this issue Nov 14, 2023 · 2 comments · May be fixed by #4344
Open

test: flaky test udp_recv_in_a_row #4219

bnoordhuis opened this issue Nov 14, 2023 · 2 comments · May be fixed by #4344
Labels
test

Comments

@bnoordhuis
Copy link
Member 

not ok 412 - udp_recv_in_a_row
# exit code 6
# Output from process `udp_recv_in_a_row`:
# Assertion failed in /Users/runner/work/libuv/libuv/test/test-udp-recv-in-a-row.c on line 54: `sizeof(send_data) == nread` (10 == 0)

That's the consequent in this if statement:

libuv/test/test-udp-recv-in-a-row.c

Lines 53 to 57 in 874363f

if (++ recv_cnt < N) {
ASSERT_EQ(sizeof(send_data), nread);
} else {
ASSERT_OK(nread);
}

And this comment may be relevant:

libuv/test/test-udp-recv-in-a-row.c

Lines 63 to 68 in 874363f

/**
* sv_recv_cb() is called with nread set to zero to indicate
* there is no more udp packet in the kernel, so the actual
* recv_cnt is one larger than N.
*/
ASSERT_EQ(N+1, recv_cnt);

@bnoordhuis bnoordhuis mentioned this issue Nov 14, 2023
Merged
bnoordhuis added a commit to bnoordhuis/libuv that referenced this issue Mar 7, 2024
@bnoordhuis
test: handle zero-length udp datagram
41710bb 
Under rare but benign circumstances, incoming datagrams are dropped by
the operating system after libuv has been notified of their arrival but
before libuv has had a chance to receive them.

Fixes: libuv#4219
@bnoordhuis bnoordhuis linked a pull request Mar 7, 2024 that will close this issue
Open
bnoordhuis added a commit to bnoordhuis/libuv that referenced this issue Mar 7, 2024
@bnoordhuis
test: handle zero-length udp datagram
9487edc 
Under rare but benign circumstances, incoming datagrams are dropped by
the operating system after libuv has been notified of their arrival but
before libuv has had a chance to receive them.

Fixes: libuv#4219
bnoordhuis added a commit to bnoordhuis/libuv that referenced this issue Mar 7, 2024
@bnoordhuis
test: handle zero-length udp datagram
02fe409 
Under rare but benign circumstances, incoming datagrams are dropped by
the operating system after libuv has been notified of their arrival but
before libuv has had a chance to receive them.

Fixes: libuv#4219
bnoordhuis added a commit to bnoordhuis/libuv that referenced this issue Mar 7, 2024
@bnoordhuis
test: handle zero-length udp datagram
f23fda9 
Under rare but benign circumstances, incoming datagrams are dropped by
the operating system after libuv has been notified of their arrival but
before libuv has had a chance to receive them.

Fixes: libuv#4219
@juanarbol
Copy link
Contributor

Also happens on macOS

@bnoordhuis
Copy link
Member Author

No, only on macos (so far anyway.) See also #4344 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: handle zero-length udp datagram bnoordhuis/libuv
2 participants
@bnoordhuis @juanarbol