Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential solution to MacOS hid_init/hid_exit issue #666

Open
k1-801 opened this issue Mar 11, 2024 · 1 comment
Open

Potential solution to MacOS hid_init/hid_exit issue #666

k1-801 opened this issue Mar 11, 2024 · 1 comment
Labels
macOS Related to macOS backend

Comments

@k1-801
Copy link

k1-801 commented Mar 11, 2024

One of the known thread-safety-related limitations on MacOS is that hid_init and hid_exit have to be called on the same thread. The only thing hid_exit really does there is destroy a HidManager. We could just leave that on the end user's shoulders, or we could resolve it internally. The problem might only arise if the user's application accidentally runs hid_init in a side thread before the main thread even gets a chance to call it (example: a static object constructor in C++ might do that).

We can't, of course, track the thread it was created in to ensure it closes in it - but, theoretically, this issue could be easily mitigated by giving the manager it's own thread to live in, which apparently would always be suspended by the sleeping RunLoop waiting for events, sacrificing zero processing power and only a small amount of ram. The manager would be created AND destroyed within the thread's function, guaranteed to be in the same thread. hid_init would have to start the thread and then wait at a barrier for the manager to be created. Then hid_exit would essentially be built the same way as hid_close, sending an event to stop the thread. That's about it.

@mcuee mcuee added the macOS Related to macOS backend label Mar 12, 2024
@Youw
Copy link
Member

Youw commented Apr 6, 2024

All true.

I was thinking about having its own thread for init/deinit on macOS.
Just never had a chance to get it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Related to macOS backend
Projects
None yet
Development

No branches or pull requests

3 participants