-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 32-bit timestamp issue in public API #735 #1220
base: master
Are you sure you want to change the base?
Conversation
…TP_ATTRIBUTES struct were limited to 32 bits on non 64 bit machines
Are we comfortable with breaking the ABI for this? If so, this will need an SO version bump. Then there is a bunch |
What reasonable options do we have that won't? |
Introducing new API variants that work with the new types. Perhaps extending this struct with new 64-bit values (while |
Adding new/duplicate API seems like not a great solution to a long term problem. Extending the struct would work, but again it's a bit of a fragile fix for a long term issue. I'd probably be OK breaking ABI but I could be convinced to keep it. :) |
I'm not for or against an ABI break, but in case we do it, it's a bigger deal; Also, before doing an SO bump, it'd be useful IMO to do a non-breaking |
I'm thinking putting this change behind an internal macro (e.g. Anyone opposing this? Edit: For documentation the pages could be duplicated into a modified, not distributed copy. Perhaps. |
libssh2 issue #735 reported that timestamp fields in LIBSSH2_SFTP_ATTRIBUTES struct were limited to 32 bits on non 64 bit machines
Closes: #735