Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Preset window sizes #467

Open
LOuroboros opened this issue Sep 22, 2021 · 3 comments
Open

Feature Request: Preset window sizes #467

LOuroboros opened this issue Sep 22, 2021 · 3 comments

Comments

@LOuroboros
Copy link

Title.
After testing out Ludo a couple of minutes just now, as a result of my latest test for #463, I noticed that a kind of basic feature is missing in Ludo's configuration menu; the ability to set a preset window size, at least when it loads a core and boots up a game.
Things like, for example, making the window's size be the native resolution for the game that is being ran, or that x2, x3, et cetera. Standalone emulators such as VisualBoyAdvance, mGBA, Snes9x, MelonDS, Duckstation and many others have something like this to name a few examples.

@kivutar
Copy link
Member

kivutar commented Sep 30, 2021

Hi, OK, It's a feature that was there at the beginning, but that I removed because it gives weird results with the menu.

The menu is designed for a wide screen. So when you play a vertical FBNeo game, and the window becomes vertical, the menu doesn't display nicely.

Since most people are playing in full screen mode to benefit of enough resolution to display a shader, do you really think it's needed?

@LOuroboros
Copy link
Author

Hi, OK, It's a feature that was there at the beginning, but that I removed because it gives weird results with the menu.

The menu is designed for a wide screen. So when you play a vertical FBNeo game, and the window becomes vertical, the menu doesn't display nicely.

Since most people are playing in full screen mode to benefit of enough resolution to display a shader, do you really think it's needed?

If I have to be honest; no, it's probably not needed. It would simply be a nice feature to have for the people that do prefer to play on windowed mode.

@bagelbyheart
Copy link
Contributor

I've been looking through some of these with the intent of trying to help clear out backlog. Ostensibly this one should be handled by the Pixel Perfect video filter, but that's actually a Sharp Bilinear. To me it seems like two things should happen:

  1. Pixel Perfect should be renamed Sharpened or Upscaled
  2. A new Pixel Perfect filter should be added that performs an integer upscale.

But that seems like the sort of thing to hear back from kivutar before putting in coding time =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants