Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictable release #108

Open
kivutar opened this issue Jan 1, 2019 · 4 comments
Open

Predictable release #108

kivutar opened this issue Jan 1, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@kivutar
Copy link
Member

kivutar commented Jan 1, 2019

The Makefile currently downloads the latest cores from the libretro buildbot during the build.

These cores may be at some point in time buggy.

We need to find a way to always pull an exact version of these cores.

In Ludo, the user shouldn't be in charge of testing and choosing the right cores and core versions. We have to do it for them in a reliable way.

@kivutar kivutar added the enhancement New feature or request label Jan 1, 2019
@kivutar kivutar pinned this issue Jan 9, 2019
@Zewwy
Copy link

Zewwy commented Jan 25, 2019

Loading custom cores will still always be an option though, right?

@RobLoach
Copy link
Member

RobLoach commented Jan 25, 2019

Yes, just stick them in ludo/cores directory.

We need to find a way to always pull an exact version of these cores.

Radius made a libretro-meta repo with some of these goals. We should really consider tagging releases of cores to help the situation. Running nightly all the time can be problematic.

@kivutar
Copy link
Member Author

kivutar commented Jan 25, 2019

That's not bad. On my side, I've tried setting up travis+github releases on cores. See my PR in the snes9x repo.

It works well most of the time.

We just need to convince the libretro team to use it.

@kivutar
Copy link
Member Author

kivutar commented Feb 5, 2019

This should already check that the core was downloaded #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants