Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lutro.conf and love.conf #58

Open
Feufochmar opened this issue Jun 15, 2016 · 0 comments
Open

lutro.conf and love.conf #58

Feufochmar opened this issue Jun 15, 2016 · 0 comments

Comments

@Feufochmar
Copy link
Contributor

The documentation of love.conf ( https://love2d.org/wiki/Config_Files ) indicates that the window width and height are configured with the keys t.window.width and t.window.height.
Currently in lutro.conf, the window width and height are configured with t.width and t.height. If lutro should follow the Löve API, this should be changed.

Currently, the settings structure that is passed to the lutro.conf has the following keys and default values:

  • t.width = 320
  • t.height = 240
  • t.live_enable = false (read in lutro_load but not set in init_settings)
  • t.live_call_load = false (read in lutro_load but not set in init_settings)

Additionnaly, the C setting structure have a field for the identity, but it is not read in the lutro_load function if the parameter t.identity is set (the field can be set with the function lutro.filesystem.setIdentity).

So I propose the following changes for the API of lutro.conf:

  • t.width become t.window.width
  • t.height become t.window.height
  • t.live_enable become t.modules.live, as this key enables the lutro module live.
  • t.live_call_load become t.livecallload, to follow the naming convention of Löve parameters
  • read the t.identity field if it is set in the lutro.conf callback

Additionnaly the t.modules options from Löve could also be taken into account for disabling lutro modules. I'm not sure if the other options from Löve make sense inside the libretro framework.

RobLoach added a commit to RobLoach/libretro-lutro that referenced this issue Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants