Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newImageFont assigns unchangeable 1 pixel of extra spacing #234

Open
ericabxy opened this issue May 29, 2022 · 5 comments
Open

newImageFont assigns unchangeable 1 pixel of extra spacing #234

ericabxy opened this issue May 29, 2022 · 5 comments

Comments

@ericabxy
Copy link

Fonts created with love.graphics.newImageFont automatically have 1 pixel of extra spacing. This is different from the default behavior of LÖVE which is 0 extra spacing. Furthermore, Lutro does not recognize the extraspacing argument, so there is no way for content to correct this behavior.

@RobLoach
Copy link
Member

Could you provide a test for this?

@ericabxy
Copy link
Author

Yes. I wrote a test using a font meant for uniform -1 kerning, demonstrating the results of constructing the font with several different "extraspacing" arguments.

extraspacing.zip

@kivutar
Copy link
Member

kivutar commented Jun 25, 2022

You're right, I need to fix this.

@ericabxy
Copy link
Author

This issue appears to have been fixed by https://github.com/libretro/libretro-lutro/commit/e9395ab4549b74670598d811ca8094be513c4c5c
Running the test file with the latest code using Lutro and LÖVE results in the same behavior in all four test cases.
I'm trying to upload a slightly updated test file in case anyone else needs to test.

@ericabxy
Copy link
Author

extraspacing.zip
Here is the new test file. It has no subfolder so be careful when extracting, or simply rename it to extraspacing.love or extraspacing.lutro to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants