Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is "lutro.graphics.scale" now working ? #199

Open
VinZombie opened this issue Apr 28, 2021 · 10 comments
Open

Is "lutro.graphics.scale" now working ? #199

VinZombie opened this issue Apr 28, 2021 · 10 comments

Comments

@VinZombie
Copy link

Hello, i'm trying to use the lutro.graphics.scale(scaleX, scaleY) function. Is it implemented ? Thank you in advance.

@kivutar
Copy link
Member

kivutar commented May 1, 2021

Hi, it's a stub, not working for now.

@VinZombie
Copy link
Author

Thank you for the answer.
Is the function possible to implement, or do I get rid of it ?
Do I have to close this issue ?

@VinZombie
Copy link
Author

(Sorry for the bad english, I'm french)

@kivutar
Copy link
Member

kivutar commented May 2, 2021

I'm French too so don't worry.

I think it's possible to implement it. It might be slow and work only for integer scaling, which is clearly not optimal.

By the way, what are you trying to scale? If it's the whole screen, there might be some other ways to handle things.

@VinZombie
Copy link
Author

Oh ! Only integers and slow function.... If I understand correctly, it is because Lutro is only software rendered ?
Yes, it's the all screen that I try to scale. It's optional, but i want to zoom out and in slowly from a 2d isometric map made of .png and .jpg files. I don't have any idea of how to do it without a scale function...
Do you have a solution ?

@RobLoach
Copy link
Member

RobLoach commented May 2, 2021

Correct, Lutro is software rendered... You could scale things manually yourself?

love.graphics.draw(drawable, x, y, r, sx, sy, ox, oy, kx, ky)

I see some stuff in the painter about scaling. Haven't tested it.

@VinZombie
Copy link
Author

VinZombie commented May 2, 2021

I have tested, i don't succed to make it work with
love.gaphics.draw(...)
Add the scale values have no effect. (Rotation doesn't have effect neither).
I tried with official version from Retroarch, compiled versions on Linux and WIndows. No success.

@kivutar
Copy link
Member

kivutar commented May 6, 2021

I also see some scaling stuff in painter which sets these two variables sx and sy.
But I don't see p->trans->sx used in any of the drawing functions.

@VinZombie
Copy link
Author

@RobLoach , @kivutar , thank you for investigate !
One question, do you think it could be possible to scale with float each sprite ? Or is it limited like global scale ?

@kivutar
Copy link
Member

kivutar commented Jun 5, 2021

I think it should be, stuff like SDL allow this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants