Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual thumbnail downloads require two attempts #16425

Open
InterClaw opened this issue Apr 9, 2024 · 0 comments
Open

Manual thumbnail downloads require two attempts #16425

InterClaw opened this issue Apr 9, 2024 · 0 comments

Comments

@InterClaw
Copy link

Description

When manually downloading thumbnails, with the title filename matching the thumbnail filenames, there are two activations of the download required before the download starts. This is regardless of the setting "Use Filenames for Thumbnail Matching".

Also, see discussion here: https://discord.com/channels/184109094070779904/469974542299955210/1226974683673530480

Expected behavior

Suggestion is that the manual downloader is "smarter" and attempts to find an exact match based on the filename on the first attempt, or at least do so when "Use Filenames for Thumbnail Matching" is enabled.

Actual behavior

Two manual download attempts are required to download based on the title filename.

Steps to reproduce the bug

  1. Ensure the title's filename is exactly matching available thumbnails.
  2. In RetroArch, go into the title and select "Download Thumbnails". The onscreen notification shows, but doesn't download anything.
  3. Select "Download Thumbnails" again. The .zip file with the thumbnails downloads.

Bisect Results

It seems this started with version 1.17.0. See this PR:
#16174

Version/Commit

You can find this information under Information/System Information

Environment information

  • OS: Windows 11 Enterprise
  • Compiler: n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant