Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playout History CSV export does not quote-delimit fields with commas #2477

Open
rjhelms opened this issue Mar 21, 2023 · 1 comment
Open
Labels
is: bug status: pinned This issue or pull request won't stale

Comments

@rjhelms
Copy link
Contributor

rjhelms commented Mar 21, 2023

Describe the bug

Playout history does not quote-delimit fields containing commas in the CSV export. This causes issues when attempting to parse the exported file.

In our instance, we use comma-delimited data in the genre field for filtering smart blocks and capturing regulatory data. An example export showing this issue: export.csv

To reproduce

  1. Go to Analytics > Playout History
  2. Filter history such that a comma appears in the data
  3. Export to CSV
  4. Attempt to load CSV file in Excel or similar program

Expected behavior

Per RFC 4180, fields containing commas should be quote-delimited.

From a glance at legacy/public/js/libs/CSVexport.js, it appears that there is no logic to handle any of the special cases in 2.6 and 2.7 of the RFC (commas, line breaks, double quotes)

Relevant log output or error messages

No response

LibreTime version

3.0.1

Installation method and OS / Environment

Operating system: Ubuntu 20.04.5 LTS
Method: install script

Installation details

No response

Client Environment

Operating system: Windows 10
Browser: Chrome 111.0.5563.65

Screenshots

No response

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 5 months. It will be closed if no activity occurs in the next month.
Please chat to us on the forum or ask for help on #libretime:matrix.org if you have any questions or need further support with getting this issue resolved.
You may also label an issue as pinned if you would like to make sure that it does not get closed by this bot.

@github-actions github-actions bot added the status: stalled This issue or pull request is stalled label Aug 19, 2023
@jooola jooola added status: pinned This issue or pull request won't stale and removed status: stalled This issue or pull request is stalled labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug status: pinned This issue or pull request won't stale
Projects
None yet
Development

No branches or pull requests

2 participants