Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #440

Open
JackZeled0n opened this issue Oct 15, 2021 · 6 comments · May be fixed by #445
Open

Add dark mode #440

JackZeled0n opened this issue Oct 15, 2021 · 6 comments · May be fixed by #445

Comments

@JackZeled0n
Copy link

Description

Add dark mode to https://librespeed.org/

Why it should be implemented

  • Can potentially reduce eye strain and dry eyes in low-light conditions
  • There will be less ‘blue light’ emitted from your devices
  • Inclusition: Some experts say dark mode can help people with light sensitivity or visual impairment.
@gaurav879
Copy link

I would like to contribute on this.

@adolfintel
Copy link
Member

Hey, sorry for the late reply.
The code for the frontend of the librespeed.org is hosted here: https://codeberg.org/librespeed/librespeed-frontend

Keep in mind that the UI in this repository is meant to be used as an example/template so adding a dark mode here would just make the examples unnecessarily complicated to read.

@JackZeled0n
Copy link
Author

@adolfintel but we would add new css for styles and few lines of js for making the switch button.

@adolfintel
Copy link
Member

If you're so keen on adding dark mode into the main repo (which I've been opposed to for years btw 😆) I suggest you use the @media (prefers-dark-interface) media query in the CSS instead of adding a button, that way it will follow the user's system preference.

I still think you should do it only on the librespeed.org website though, the examples are already long enoguh.

@JackZeled0n
Copy link
Author

Ok 😅
Thanks @adolfintel

@TheSheref TheSheref linked a pull request Nov 5, 2021 that will close this issue
@EpicLPer
Copy link

Have there been any updates on this 😅
I just deployed this as a Docker container and honestly it works great, the only real downside so far is that it basically flashbangs me whenever I open the page 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants