Skip to content
This repository has been archived by the owner on Jun 18, 2022. It is now read-only.

Translation Multilingual #16

Open
sergiolps opened this issue Oct 8, 2017 · 7 comments
Open

Translation Multilingual #16

sergiolps opened this issue Oct 8, 2017 · 7 comments
Labels
translation 🎏 Translation support

Comments

@sergiolps
Copy link

I would like to collaborate with the Translation of the App to (pt_BR) Brazilian Portuguese

@pheinrichs
Copy link
Collaborator

This will be great, i'm adding multi language implementation right now, once i'm finished I will be open sourcing this project.

@sergiolps
Copy link
Author

Great

Please open that I would like to reply with the translation.

Thank you very much!

@laf
Copy link
Member

laf commented Jan 10, 2018

It's been released (thank you so much @pheinrichs :)).

@sergiolps https://github.com/pheinrichs/myLibreNMS/tree/master/src/assets/i18n Looking forward to seeing your PR :)

@telskamp
Copy link
Contributor

telskamp commented May 31, 2018

I made a pull request for my dutch translation file, I did notice however that the language -tags used do not include the country/region code (for example en-US instead of just "en" ) I think it would be best to start off using those right from the start because languages can differ a lot depending on country, for example en-UK is really different from en-US while both are considered "English"

@laf
Copy link
Member

laf commented May 31, 2018

So the code for language support takes the value before the - currently. I expect that's to simplify things as -UK and -US for the most part here will be the same.

Something like: ngx-translate/core#393 maybe. Try and use a more specific and if not fall back to the X- part?

@laf laf added the translation 🎏 Translation support label May 31, 2018
@pheinrichs
Copy link
Collaborator

If ever we get another translation for multiple region codes I think we can remove the logic at that time. They'll both require an update anyway so it's not that big of an caveat.

@sergiolps
Copy link
Author

sergiolps commented Apr 1, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
translation 🎏 Translation support
Projects
None yet
Development

No branches or pull requests

4 participants