Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs after apply commit https://github.com/librenms/librenms/pull/15940 #15986

Open
LEV82 opened this issue Apr 26, 2024 · 4 comments
Open

Bugs after apply commit https://github.com/librenms/librenms/pull/15940 #15986

LEV82 opened this issue Apr 26, 2024 · 4 comments

Comments

@LEV82
Copy link
Contributor

LEV82 commented Apr 26, 2024

The problem

Found a bug's in the charts after applying the commit #15940.
The delay to some of my devices is more than 1 second

image

  1. Y axis on the right side is written as Loss, but the scale corresponds to the delay.
  2. If the delay is more than 1 second, the scale on the right side is incorrectly displayed
  3. The maximum delay is calculated incorrectly.

Ping chart same device
image

Output of ./validate.php

===========================================
Component | Version
--------- | -------
LibreNMS  | 24.4.1-9-g43e6846cb (2024-04-26T04:36:16+08:00)
DB Schema | 2024_04_22_161711_custom_maps_add_group (292)
PHP       | 8.2.9
Python    | 3.10.12
Database  | MariaDB 10.6.16-MariaDB-0ubuntu0.22.04.1
RRDTool   | 1.7.2
SNMP      | 5.9.1
===========================================

[OK]    Composer Version: 2.6.5
[OK]    Dependencies up-to-date.
[OK]    Database connection successful
[OK]    Database Schema is current
[OK]    SQL Server meets minimum requirements
[OK]    lower_case_table_names is enabled
[OK]    MySQL engine is optimal
[OK]    Database and column collations are correct
[OK]    Database schema correct
[OK]    MySQL and PHP time match
[OK]    Distributed Polling setting is enabled globally
[OK]    Connected to rrdcached
[OK]    Active pollers found
[OK]    Dispatcher Service is enabled
[OK]    Locks are functional
[OK]    Python wrapper cron entry is not present
[OK]    Redis is functional
[WARN]  IPv6 is disabled on your server, you will not be able to add IPv6 devices.
[OK]    rrdtool version ok
[OK]    Connected to rrdcached
[WARN]  Your install is over 24 hours out of date, last update: Thu, 25 Apr 2024 20:36:16 +0000
        [FIX]:
        Make sure your daily.sh cron is running and run ./daily.sh by hand to see if there are any errors.

What was the last working version of LibreNMS?

No response

Anything in the logs that might be useful for us?

No response

LEV82 referenced this issue Apr 26, 2024
* Improved Latency graph
Store loss+jitter info in rrd instead of database
New graph icmp_perf (legacy ping_perf still valid referencing part of the newer data)
Delete device_perf table

* Change loss to an area so it is more visible

* Style fixes

* Cleanups from phpstan & tests

* exit_code fix

* Remove alert usage of device_perf

* Don't use magic __get

* Add test for bulkPing
Add host to previous tests

* style fixes

* Fix issue fping error responses
@murrant
Copy link
Member

murrant commented May 6, 2024

I could not find a way to make the right side scale independently from the left. (and stop at 100%)
The left side of your graph looks very bizarre. I have no idea what to make of this as I don't know what values you expect.

@LEV82
Copy link
Contributor Author

LEV82 commented May 7, 2024

Hi,
On the right side instead of packet loss I see a delay, maximum delay of 2.0 k which corresponds to a delay of 2000ms.
On the left side I expected to see values on the order of 2000ms instead I see 2ms.

@murrant
Copy link
Member

murrant commented May 7, 2024

I think the m is not supposed to be there and it is showing 1s and 2s.

I already explained the right side displays as expected. If any rrdtool experts have any idea how to limit the scale to 100, that would be great.

@LEV82
Copy link
Contributor Author

LEV82 commented May 7, 2024

That is correct, the “m” should not be there.

I meant that the right side of the scale displays the delay, not the loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants