Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test conditions to repository #815

Open
1fexd opened this issue Sep 2, 2023 · 19 comments
Open

Add test conditions to repository #815

1fexd opened this issue Sep 2, 2023 · 19 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@1fexd
Copy link

1fexd commented Sep 2, 2023

Hi,

do you guys have something like unit tests where you test if your rewrites to free frontends actually work?

Kind Regards

@IkelAtomig
Copy link
Member

I don't understand the question actually.

@1fexd
Copy link
Author

1fexd commented Sep 4, 2023

In https://github.com/libredirect/browser_extension/blob/master/src/assets/javascripts/services.js#L114 you rewrite regular URLs to libre frontends - but are there actually any tests (like unit tests or something like that?) that ensure the functionality is working correctly?

@IkelAtomig
Copy link
Member

Yeah, I have set of URLs in a markdown file. I just open the link and it extension redirects. I have specific sites to check for embeds.

I am the tester. I rigorously test every frontend whether it is changed or not to ensure it is functional before releasing both in chromium (Need to check on other Chromium browsers too though in later time) and Firefox.

@1fexd
Copy link
Author

1fexd commented Sep 7, 2023

Would it be possible to include this file in the repo? Or even better, add proper unit tests? Because I am working on an implementation of this extension in Kotlin for my Android app so tests would be super helpful.

@IkelAtomig
Copy link
Member

Could you please remind me tomorrow ?

@ManeraKai
Copy link
Member

@IkelAtomig

@1fexd
Copy link
Author

1fexd commented Sep 10, 2023

Hello, it's tomorrow now :)

@IkelAtomig
Copy link
Member

Testing.md

Sorry for the delay. This is mostly I use during testing. Certain things might be missing but major frontends are here.

@1fexd
Copy link
Author

1fexd commented Sep 12, 2023

I think there should be test cases for this huge switch. so it can be checked if it actually works.

@NoPlagiarism
Copy link
Contributor

Also, I think, Testing.md should be published in repository. So, if someone making any changes

  1. They can test it themselves
  2. They can add new test for those changes

@IkelAtomig
Copy link
Member

Yeah, sure. I will add it. Just busy IRL.

@1fexd
Copy link
Author

1fexd commented Sep 20, 2023

Maybe re-open this until you have time?

@IkelAtomig
Copy link
Member

Good Idea.

@IkelAtomig IkelAtomig reopened this Sep 21, 2023
@IkelAtomig IkelAtomig changed the title Tests Add test conditions to repository Sep 21, 2023
@ManeraKai ManeraKai added the documentation Improvements or additions to documentation label Oct 12, 2023
@ManeraKai
Copy link
Member

Any updates @IkelAtomig?

@IkelAtomig
Copy link
Member

Will be uploaded during the next release.

@NoPlagiarism
Copy link
Contributor

With merging #903, this issue will look very interesting

@IkelAtomig
Copy link
Member

IkelAtomig commented Mar 22, 2024

Ah s**t, I really need to get back here. Life sucks ...

@ManeraKai
Copy link
Member

@IkelAtomig

@IkelAtomig
Copy link
Member

ETA Sunday. Promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

No branches or pull requests

4 participants