Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options.ctol to prima_is_success #195

Open
nbelakovski opened this issue Apr 30, 2024 · 1 comment
Open

Add options.ctol to prima_is_success #195

nbelakovski opened this issue Apr 30, 2024 · 1 comment

Comments

@nbelakovski
Copy link
Contributor

nbelakovski commented Apr 30, 2024

This was discussed in the Python binding PR but not implemented. Something that would need to change to accommodate this would be setting the default options.ctol in C to sqrt(eps), which means we could no longer pass it to Fortran as an optional parameter.

Alternatively, in prima_is_success we could check if option.ctol is NaN and use sqrt(eps) if so, but I seem to recall there were some issues with NaN checks with certain compilers and options?

@zaikunzhang
Copy link
Member

I see the issue ...

nbelakovski added a commit to nbelakovski/prima that referenced this issue May 1, 2024
nbelakovski added a commit to nbelakovski/prima that referenced this issue May 1, 2024
nbelakovski added a commit to nbelakovski/prima that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants