Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either make tests and examples independent or enable examples when building tests #120

Open
barracuda156 opened this issue Dec 10, 2023 · 1 comment

Comments

@barracuda156
Copy link

Tests do not run if examples are not explicitly enabled in the build. This is somewhat counter-intuitive: perhaps, either make these separate or make examples a part of tests without a separate configure setting. Otherwise running tests with -DPRIMA_ENABLE_TESTING=ON but without -DPRIMA_ENABLE_EXAMPLES=ON leaves all tests broken.

@zaikunzhang
Copy link
Member

Tests do not run if examples are not explicitly enabled in the build. This is somewhat counter-intuitive: perhaps, either make these separate or make examples a part of tests without a separate configure setting. Otherwise running tests with -DPRIMA_ENABLE_TESTING=ON but without -DPRIMA_ENABLE_EXAMPLES=ON leaves all tests broken.

@jschueller Could you have a look! Shouldn't DPRIMA_ENABLE_EXAMPLES be set to ON if DPRIMA_ENABLE_TESTING is ON? Or should we merge the two options? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants