Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit Relay v2 should not publish routing key without public addresses #2500

Closed
achingbrain opened this issue Apr 23, 2024 · 1 comment
Closed
Labels
need/triage Needs initial labeling and prioritization

Comments

@achingbrain
Copy link
Member

If a node has no publicly diallable non-relay addresses it shouldn't publish a provider record saying it is a circuit relay server, much like kad-dht requires public addresses to become a server.

The JS implementation may not do this, but it needs double-checking because I think I saw a provider record for a JS peer that only had relay addresses.

@achingbrain achingbrain added the need/triage Needs initial labeling and prioritization label Apr 23, 2024
@achingbrain
Copy link
Member Author

Closing in favour of #2545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant