Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDial retries creeps up CPU usage over time #2418

Open
mkykadir opened this issue Feb 19, 2024 · 3 comments
Open

AutoDial retries creeps up CPU usage over time #2418

mkykadir opened this issue Feb 19, 2024 · 3 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@mkykadir
Copy link

  • Version: 1.2.3

  • Platform: Linux 7e698928f50f 5.15.49-linuxkit-pr #1 SMP PREEMPT Thu May 25 07:27:39 UTC 2023 aarch64 Linux

  • Subsystem: Connection manager

Severity: Medium

Description: I was relying on ConnectionManager's minConnections configuration's default value to be 0 but after an update this default value increased to 50. My P2P network does not have that much nodes, since minConnections become 50; autoDial keeps trying to dialing new nodes and this creates increase in CPU usage over time; which eventually overloads node.js event loop.

Steps to reproduce the error: Set minConnections config a high number; let node to autoDial over time and monitor Node's CPU usage over time. This can take time.

@mkykadir mkykadir added the need/triage Needs initial labeling and prioritization label Feb 19, 2024
@abuvanth
Copy link

set in config

connectionManager: {
      minConnections: 5
    },

@mkykadir
Copy link
Author

yes I already did that as a temporary fix but I don't think this auto dialing feature should creep up memory and cpu usage over time; its really hard to mitigate and identify the exact root cause

@abuvanth
Copy link

yes I already did that as a temporary fix but I don't think this auto dialing feature should creep up memory and cpu usage over time; its really hard to mitigate and identify the exact root cause

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants