notifyOnTransient also ignore disconnection events?

[marcus-pousette]

• Version:
  1.1.0

• Subsystem:
  registrar

Severity:

Medium/low

Description:

It seems like onDisconnect events are still emitted from transient connections shutting down even if notifyOnTransient is false.

I am receiving onDisconnect events when failing to establish a WebRTC connection

Steps to reproduce the error:

The seems to be intended behaviour (judging by the code).

js-libp2p/packages/libp2p/src/registrar.ts

Line 167 in f27138c

topology.onDisconnect?.(remotePeer)

Is it possible to fetch the closing connection here and skip if transient and notifyOnTransient is false ?

Feels more intuitive that connect and disconnect events are handled in the same way.