Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: @libp2p/webrtc depends on deprecated packages #2264

Open
SgtPooki opened this issue Nov 29, 2023 · 1 comment · May be fixed by #2522
Open

deps: @libp2p/webrtc depends on deprecated packages #2264

SgtPooki opened this issue Nov 29, 2023 · 1 comment · May be fixed by #2522
Assignees

Comments

@SgtPooki
Copy link
Member

We should remove the dependencies on deprecated packages.

I'm working on removing all the old ipld/ipfs deps from ipld-explorer-components and saw the following when npm installing:

npm WARN deprecated multibase@4.0.6: This module has been superseded by the multiformats module

I ran npm why to determine what was up:

╰─ ✔ ❯ npm why multibase
multibase@4.0.6
node_modules/multibase
  multibase@"^4.0.1" from multihashes@4.0.3
  node_modules/multihashes
    multihashes@"^4.0.3" from @libp2p/webrtc@4.0.0
    node_modules/@libp2p/webrtc
      @libp2p/webrtc@"^4.0.0" from the root project
    multihashes@"^4.0.3" from @libp2p/webrtc@3.2.11
    node_modules/helia/node_modules/@libp2p/webrtc
      @libp2p/webrtc@"^3.1.3" from helia@2.1.0
      node_modules/helia
        helia@"^2.1.0" from the root project

╭─    ~/c/work/p/ipfs/ipld-explorer-components    deps/refresh *4 ?4 
╰─ ✔ ❯ npm why multihashes
multihashes@4.0.3
node_modules/multihashes
  multihashes@"^4.0.3" from @libp2p/webrtc@4.0.0
  node_modules/@libp2p/webrtc
    @libp2p/webrtc@"^4.0.0" from the root project
  multihashes@"^4.0.3" from @libp2p/webrtc@3.2.11
  node_modules/helia/node_modules/@libp2p/webrtc
    @libp2p/webrtc@"^3.1.3" from helia@2.1.0
    node_modules/helia
      helia@"^2.1.0" from the root project
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Nov 29, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue May 2, 2024
@maschad maschad linked a pull request May 2, 2024 that will close this issue
3 tasks
@maschad maschad removed the need/triage Needs initial labeling and prioritization label May 7, 2024
@maschad maschad self-assigned this May 7, 2024
@dhuseby
Copy link
Contributor

dhuseby commented May 7, 2024

Waiting for #2522 to land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏃‍♀️In Progress
Development

Successfully merging a pull request may close this issue.

3 participants