Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update React Native instructions in config #2540

Merged
merged 4 commits into from May 16, 2024
Merged

docs: update React Native instructions in config #2540

merged 4 commits into from May 16, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented May 11, 2024 •
edited

Title

docs: update React Native instructions in config

Description

Updates the docs with current state of React Native support. Closes #2136

Notes & open questions

I'm not sure if this necessarily the best place to put these instructions, open to feedback

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@maschad maschad requested a review from a team as a code owner May 11, 2024 02:36
@maschad maschad self-assigned this May 11, 2024
achingbrain
achingbrain requested changes May 14, 2024
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good thing to link to but I don't think it belongs in this doc.

The point of this doc is "How do I configure my node?", ie. "What can I pass to the createLibp2p function".

Perhaps add it to GETTING_STARTED.md instead?

@maschad maschad requested a review from achingbrain May 14, 2024 20:18
@achingbrain achingbrain merged commit 5b73802 into libp2p:main May 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees

@maschad maschad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React Native support
2 participants
@maschad @achingbrain