Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libCEED Travis CI With OCCA Now Failing #198

Closed
jeremylt opened this issue Aug 26, 2018 · 12 comments
Closed

libCEED Travis CI With OCCA Now Failing #198

jeremylt opened this issue Aug 26, 2018 · 12 comments

Comments

@jeremylt
Copy link
Contributor

A recent update to OCCA now gives a failure in Travis for OCCA for all examples, CEED, MFEM, and PETSc. I suspect there is a change that needs to get updated in our OCCA backends

PR Link with failing Travis:
CEED/libCEED#143

@jeremylt
Copy link
Contributor Author

This commit works with libCEED

527494c

@dmed256
Copy link
Member

dmed256 commented Aug 27, 2018

My bad, accidentally pushed a bad commit to master

@jeremylt
Copy link
Contributor Author

No worries. I just wanted to make sure you knew because it could have been something we needed to adjust on our end.

@dmed256 dmed256 closed this as completed Aug 27, 2018
@jeremylt
Copy link
Contributor Author

I'm still seeing the issue. I made a PR for libCEED that runs Travis against the last version of OCCA that libCEED passes with.

CEED/libCEED#145

@dmed256
Copy link
Member

dmed256 commented Aug 27, 2018

Oops, misread the hash. Thought it was the HEAD commit at the time.
I'll check this tonight, my bad

@jeremylt
Copy link
Contributor Author

No worries, thanks for looking into it

@dmed256
Copy link
Member

dmed256 commented Sep 1, 2018

@jeremylt seems the new kernelHash method is messing something up

https://github.com/libocca/occa/blob/master/src/device.cpp#L442

Changing it back to occa::hash(allProps) seems to make libCEED tests pass again. I'll keep looking to find out the root cause, just wanted to update you on that

@v-dobrev
Copy link
Contributor

v-dobrev commented Sep 1, 2018

By the way, @dmed256, I think this issue also affects mfem's engines-dev branch and probably occa-dev as well.

@jeremylt
Copy link
Contributor Author

jeremylt commented Sep 1, 2018

Thanks for the update!

@dmed256
Copy link
Member

dmed256 commented Sep 1, 2018

@jeremylt @v-dobrev Just tested libCEED with origin/master (1450f74) and it passes again

@v-dobrev
Copy link
Contributor

v-dobrev commented Sep 1, 2018

Thanks, David! I'll give it a try with mfem.

@v-dobrev
Copy link
Contributor

v-dobrev commented Sep 2, 2018

The latest commit (780a06a) works OK with mfem (engines-dev).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants