implements MasterKeyChangeForce Meta key #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key name is defined here and is always present in the DB XML: https://github.com/dlech/KeePass2.x/blob/6bb7f0cbe1afa5365fcdbed7adc124e82ac01fef/KeePassLib/Serialization/KdbxFile.cs#L118 The type is always C# Long: https://github.com/dlech/KeePass2.x/blob/6bb7f0cbe1afa5365fcdbed7adc124e82ac01fef/KeePassLib/Serialization/KdbxFile.Read.Streamed.cs#L248 The behavior is triggered after >= 0 check: https://github.com/dlech/KeePass2.x/blob/0defb69f48687de62a4dbfad3213387371a3e8be/KeePass/Forms/DatabaseSettingsForm.cs#L235
|
Simple example: from pykeepass import create_database
db = create_database("db.kdbx")
assert db.password_change_force_days == -1
assert not db.needs_password_change
print(db.xml())
# open with the password for blank DB (embedded in the codebase) via UI tool
# no effect, close
# enforce password change
db.password_change_force_days = 0 # immediately
assert db.password_change_force_days == 0
assert db.needs_password_change
db.save()
print(db.xml())
# open with the password for blank DB (embedded in the codebase) via UI tool
# UI needs to enforce master password change immediately |
|
lgtm |
|
@pschmitt Please approve it via |
|
We need to check when the masterkey was set for this to make sense. I don't see any datetime parsing happening here, so I don't understand how this is supposed to work. These are the fields we need to read/set: So something like: @property
def masterkey_change_required(self):
change_date = self._decode_time(self._xpath('/KeePassFile/Meta/MasterKeyChanged'))
max_days = self._xpath('/KeePassFile/Meta/MasterKeyChangeForce')
return (datetime.now() - change_date).days > max_days
@property
def masterkey_change_recommended(self):
change_date = self._decode_time(self._xpath('/KeePassFile/Meta/MasterKeyChanged'))
max_days = self._xpath('/KeePassFile/Meta/MasterKeyChangeRec')
return (datetime.now() - change_date).days > max_daysAlso And tests. |
|
Looking at the keepass2 code linked above, I think the booleans
|
|
This was implemented in 9811ac0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the forceful password change trigger which happens once a person opens the DB in a KDBX-compatible UI tool.
Closes #269